[ 
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220573#comment-15220573
 ] 

ASF GitHub Bot commented on STORM-1632:
---------------------------------------

Github user roshannaik commented on the pull request:

    https://github.com/apache/storm/pull/1217#issuecomment-204101205
  
    1. I spent sometime trying to see if the tooltip can show up faster. But 
there is a catch-22 there. The Bootstrap based tooltip mechanism allows it, but 
the Bootstrap based tooltips wont show up if button is disabled. So had to 
settle for this mechanism... which has a downside that it doesnt allow 
customization of color and timing to the best i could check.  The solution you 
describe here is among one of the alternative I had already tried and it 
doesn't work.  The tooltip wont show up unless you hover the mouse over the 
boundary between the enclosing span element and the disabled button.
    
    2. & 3.  Although nice to not show tooltip when enabled, I thought its OK 
to show the tooltip in both enabled/disabled states of the button. Given the 
desire for quick turn around, i felt it was wise to not pursue 
implementing/testing this nice to have, but non-critical feature. 
    
    4. Let me look into that.


> Disable event logging by default
> --------------------------------
>
>                 Key: STORM-1632
>                 URL: https://issues.apache.org/jira/browse/STORM-1632
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>            Priority: Blocker
>         Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology  
> with a single instances of a spout and a bolt, disabling event logging 
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off 
> by default.
> **Update:** with acker=0  the observed impact was much higher... **25%** 
> faster when event loggers = 0 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to