[
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226981#comment-15226981
]
ASF GitHub Bot commented on STORM-1632:
---------------------------------------
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/1217#discussion_r58601713
--- Diff: storm-core/src/ui/public/js/script.js ---
@@ -220,19 +220,21 @@ function topologyActionJson(id, encodedId, name,
status, msgTimeout, debug, samp
jsonData["deactivateStatus"] = (status === "ACTIVE") ? "enabled" :
"disabled";
jsonData["rebalanceStatus"] = (status === "ACTIVE" || status ===
"INACTIVE" ) ? "enabled" : "disabled";
jsonData["killStatus"] = (status !== "KILLED") ? "enabled" :
"disabled";
- jsonData["startDebugStatus"] = (status === "ACTIVE" && !debug) ?
"enabled" : "disabled";
+ jsonData["startDebugStatus"] = (status === "ACTIVE" &&
loggersTotal!=null && loggersTotal!=0 && !debug) ? "enabled" : "disabled";
--- End diff --
Since the intent is to disable event logging by default, we should disable
logging if topology.eventlogger.executors is null ... otherwise its
confusing.
> Disable event logging by default
> --------------------------------
>
> Key: STORM-1632
> URL: https://issues.apache.org/jira/browse/STORM-1632
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Priority: Blocker
> Fix For: 1.0.0
>
> Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology
> with a single instances of a spout and a bolt, disabling event logging
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off
> by default.
> **Update:** with acker=0 the observed impact was much higher... **25%**
> faster when event loggers = 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
