[ 
https://issues.apache.org/jira/browse/STORM-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234178#comment-15234178
 ] 

ASF GitHub Bot commented on STORM-1693:
---------------------------------------

GitHub user abhishekagarwal87 opened a pull request:

    https://github.com/apache/storm/pull/1326

    STORM-1693: Do not cancel the task after stats are rendered

    Fresher task is cancelled right after 3 seconds when executor heartbeat is 
sent. getValueAndReset can rotate the buckets but it is not time bound. Metric 
tick is in same queue as the input tuples from spout. If processing input 
tuples is slow, it may take much more to generate metrics and call 
getValueAndReset and thus `System.currentTimeMillis() - _bucketStart` is more 
than 10 minutes. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abhishekagarwal87/storm STORM-1693

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1326
    
----
commit 884b051b3fcdd49cb8a0df52b57b685d6b36f858
Author: Abhishek Agarwal <[email protected]>
Date:   2016-04-10T16:12:19Z

    STORM-1693: Do not cancel the task after stats are rendered

----


> Negative counts in the UI for __metrics stream
> ----------------------------------------------
>
>                 Key: STORM-1693
>                 URL: https://issues.apache.org/jira/browse/STORM-1693
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>            Priority: Critical
>         Attachments: Screen Shot 2016-04-07 at 7.05.01 PM.png
>
>
> Metrics reported by UI are not correct. I am seeing negative counts for 
> output stats in the bolt. The same application code works fine on 0.9.6 
> version of storm. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to