[
https://issues.apache.org/jira/browse/STORM-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235176#comment-15235176
]
ASF GitHub Bot commented on STORM-1693:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59214896
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/internal/CountStatAndMetric.java ---
@@ -197,12 +196,6 @@ long readApproximateTime(long value, long timeSpent,
long[] bucketTime, long[] b
return total;
}
- public void close() {
- if (_task != null) {
- _task.cancel();
--- End diff --
If we don't cancel it we leak memory and other things in the tests. We at
least need to close the stat when we are all done, not after calling
render-stats.
> Negative counts in the UI for __metrics stream
> ----------------------------------------------
>
> Key: STORM-1693
> URL: https://issues.apache.org/jira/browse/STORM-1693
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
> Priority: Critical
> Attachments: Screen Shot 2016-04-07 at 7.05.01 PM.png
>
>
> Metrics reported by UI are not correct. I am seeing negative counts for
> output stats in the bolt. The same application code works fine on 0.9.6
> version of storm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
