[
https://issues.apache.org/jira/browse/STORM-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235196#comment-15235196
]
ASF GitHub Bot commented on STORM-1693:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59215960
--- Diff: storm-core/src/clj/org/apache/storm/stats.clj ---
@@ -188,14 +168,12 @@
(defn value-bolt-stats!
[^BoltExecutorStats stats]
- (cleanup-bolt-stats! stats)
(merge (value-common-stats (:common stats))
(value-stats stats BOLT-FIELDS)
{:type :bolt}))
(defn value-spout-stats!
[^SpoutExecutorStats stats]
- (cleanup-spout-stats! stats)
--- End diff --
Really the issue is just that cleanup-bolt-stats! and cleanup-spout-stats!
needs to move from value-*-stats! to something that is called from the executor
shutdown.
https://github.com/abhishekagarwal87/storm/blob/STORM-1693/storm-core/src/clj/org/apache/storm/daemon/executor.clj#L409-L417
I thought that is where they were called from when I saw them, but I
obviously was wrong.
> Negative counts in the UI for __metrics stream
> ----------------------------------------------
>
> Key: STORM-1693
> URL: https://issues.apache.org/jira/browse/STORM-1693
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
> Priority: Critical
> Attachments: Screen Shot 2016-04-07 at 7.05.01 PM.png
>
>
> Metrics reported by UI are not correct. I am seeing negative counts for
> output stats in the bolt. The same application code works fine on 0.9.6
> version of storm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
