[
https://issues.apache.org/jira/browse/STORM-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244294#comment-15244294
]
ASF GitHub Bot commented on STORM-1705:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1331#discussion_r59970071
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/PartitionManager.java ---
@@ -46,6 +46,9 @@
private final CountMetric _fetchAPIMessageCount;
--- End diff --
since we are refactoring this code. Can we simplify partitionManager
constructor instead of the current state we can have few private methods for
all the code in the constructor.
> Cap on number of retries for a failed message in kafka spout
> ------------------------------------------------------------
>
> Key: STORM-1705
> URL: https://issues.apache.org/jira/browse/STORM-1705
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-kafka
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
> The kafka-spout module based on newer APIs has a cap on the number of times,
> a message is to be retried. It will be a good feature add in the older kafka
> spout code as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
