[
https://issues.apache.org/jira/browse/STORM-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321242#comment-15321242
]
ASF GitHub Bot commented on STORM-1705:
---------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1331#discussion_r66318933
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ExponentialBackoffMsgRetryManager.java
---
@@ -86,15 +94,23 @@ public Long nextFailedMessageToRetry() {
}
@Override
- public boolean shouldRetryMsg(Long offset) {
+ public boolean shouldReEmitMsg(Long offset) {
MessageRetryRecord record = this.records.get(offset);
return record != null &&
this.waiting.contains(record) &&
System.currentTimeMillis() >= record.retryTimeUTC;
--- End diff --
I would be nice to log a WARN message when we are dropping messages so
users have a way of knowing when/why it is happening.
> Cap on number of retries for a failed message in kafka spout
> ------------------------------------------------------------
>
> Key: STORM-1705
> URL: https://issues.apache.org/jira/browse/STORM-1705
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-kafka
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
> The kafka-spout module based on newer APIs has a cap on the number of times,
> a message is to be retried. It will be a good feature add in the older kafka
> spout code as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
