[
https://issues.apache.org/jira/browse/STORM-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245248#comment-15245248
]
ASF GitHub Bot commented on STORM-1714:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1343#discussion_r60016236
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/CheckpointTupleForwarder.java ---
@@ -53,6 +53,10 @@
private long lastTxid = Long.MIN_VALUE;
private AnchoringOutputCollector collector;
+ public CheckpointTupleForwarder() {
--- End diff --
Oh I'm seeing StatefulBoltExecutor extends this class.
IMO StatefulBoltExecutor extending CheckpointTupleForwarder could make us
confusing, since StatefulBoltExecutor always call default constructor of
CheckpointTupleForwarder, which means that StatefulBoltExecutor should hide all
methods which access (directly or indirectly) this.bolt to avoid NPE.
Could we introduce base class extracting common logic from
CheckpointTupleForwarder?
> StatefulBolts ends up as normal bolts while using TopologyBuilder.setBolt
> without parallelism
> ---------------------------------------------------------------------------------------------
>
> Key: STORM-1714
> URL: https://issues.apache.org/jira/browse/STORM-1714
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> StatefulBolt inherits from IRichBolt which but the TopologyBuilder.setBolt
> overload is chosen based on the static type of the parameter causing issues.
> See if StatfulBolt can be refactored to not directly inherit from IRichBolt.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
