[ 
https://issues.apache.org/jira/browse/STORM-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246987#comment-15246987
 ] 

ASF GitHub Bot commented on STORM-1714:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1343#discussion_r60164876
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/topology/StatefulBoltExecutor.java ---
    @@ -74,6 +71,23 @@ void prepare(Map stormConf, TopologyContext context, 
OutputCollector collector,
         }
     
         @Override
    +    public void cleanup() {
    +        bolt.cleanup();
    +    }
    +
    +    @Override
    +    public void declareOutputFields(OutputFieldsDeclarer declarer) {
    +        bolt.declareOutputFields(declarer);
    +        super.declareCheckpointStream(declarer);
    --- End diff --
    
    Nit: It doesn't need to be called with `super.`.


> StatefulBolts ends up as normal bolts while using TopologyBuilder.setBolt 
> without parallelism
> ---------------------------------------------------------------------------------------------
>
>                 Key: STORM-1714
>                 URL: https://issues.apache.org/jira/browse/STORM-1714
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>
> StatefulBolt inherits from IRichBolt which but the TopologyBuilder.setBolt 
> overload is chosen based on the static type of the parameter causing issues. 
> See if StatfulBolt can be refactored to not directly inherit from IRichBolt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to