[
https://issues.apache.org/jira/browse/STORM-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259294#comment-15259294
]
ASF GitHub Bot commented on STORM-1731:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1364
STORM-1731 (0.10.x) Avoid looking up debug / backpressure enable flags
within critical path
* preload the value of flags and use that value
* topology.debug
Pull request for 1.x version is here: #1362
I don't take performance tests on this pull request, since #1362 shows the
benefit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1731-0.10.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1364
----
commit 1cc5228e3195826836e353342407fea290ea9122
Author: Jungtaek Lim <[email protected]>
Date: 2016-04-27T01:03:04Z
STORM-1731 Avoid looking up debug / backpressure enable flags within
critical path
* preload the value of flags and use that value
* topology.debug
----
> Avoid looking up debug / backpressure enable flags within critical path
> -----------------------------------------------------------------------
>
> Key: STORM-1731
> URL: https://issues.apache.org/jira/browse/STORM-1731
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> While profiling the result of STORM-1729, I also found that there're many
> places in critical path which look up the value of flags which are not
> updated dynamically.
> ("get from map" is on top 5 from each spout / bolt thread.)
> This should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
