[
https://issues.apache.org/jira/browse/STORM-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259402#comment-15259402
]
ASF GitHub Bot commented on STORM-1731:
---------------------------------------
Github user roshannaik commented on the pull request:
https://github.com/apache/storm/pull/1362#issuecomment-214948085
Ran the provided topology and a couple minor variations with this
cumulative fix.
Was able to measure a 50% boost in throughput (ACKs/sec) on the
1.x-branch. Also verified that the event logging feature continues to work
correctly.
I used Topology level ACKs/sec from the UI instead of emits/sec since IMO
its a better metric to gauge throughput.
**1.x-branch:** ACK/s = 226,473 & Latency = 4.5ms
**With fixes:** ACK/s = 341,454 & Latency = 3.47ms
> Avoid looking up debug / backpressure enable flags within critical path
> -----------------------------------------------------------------------
>
> Key: STORM-1731
> URL: https://issues.apache.org/jira/browse/STORM-1731
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> While profiling the result of STORM-1729, I also found that there're many
> places in critical path which look up the value of flags which are not
> updated dynamically.
> ("get from map" is on top 5 from each spout / bolt thread.)
> This should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
