[
https://issues.apache.org/jira/browse/STORM-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264293#comment-15264293
]
ASF GitHub Bot commented on STORM-1725:
---------------------------------------
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1382
STORM-1725: Kafka Spout New Consumer API -
KafkaSpoutRetryExponentialBackoff method should use HashMap instead of TreeMap
not to throw Exception
- Replace TreeMap with HashMap
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache master_STORM-1725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1382
----
commit 3702df4abfcad3537847f5aa957aaf243c1860a0
Author: Hugo Louro <[email protected]>
Date: 2016-04-22T17:16:31Z
STORM-1725: Kafka Spout New Consumer API -
KafkaSpoutRetryExponentialBackoff method should use HashMap instead of TreeMap
not to throw Exception
- Replace TreeMap with HashMap
----
> Kafka Spout New Consumer API - KafkaSpoutRetryExponentialBackoff method
> should use HashMap instead of TreeMap not to throw Exception
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-1725
> URL: https://issues.apache.org/jira/browse/STORM-1725
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-kafka
> Affects Versions: 1.0.0
> Reporter: Hugo Louro
> Assignee: Hugo Louro
> Priority: Blocker
> Fix For: 1.0.1
>
>
> The method
> org.apache.storm.kafka.spout.KafkaSpoutRetryExponentialBackoff#retriableTopicPartitions
> currently uses TreeMap but TopicPartition does not implement Comparable.
> Since ordering is not important, HashMap is the most appropriate data
> structure here, and the one I meant to use to begin with.
> The fix will replace TreeMap with HashMap.
> This issue was found by @jianbzhou and credit should be given to him.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
