[ https://issues.apache.org/jira/browse/STORM-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268333#comment-15268333 ]
ASF GitHub Bot commented on STORM-1725: --------------------------------------- Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1382#issuecomment-216463802 +1 > Kafka Spout New Consumer API - KafkaSpoutRetryExponentialBackoff method > should use HashMap instead of TreeMap not to throw Exception > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: STORM-1725 > URL: https://issues.apache.org/jira/browse/STORM-1725 > Project: Apache Storm > Issue Type: Bug > Components: storm-kafka > Affects Versions: 1.0.0 > Reporter: Hugo Louro > Assignee: Hugo Louro > Priority: Blocker > Fix For: 1.0.1 > > > The method > org.apache.storm.kafka.spout.KafkaSpoutRetryExponentialBackoff#retriableTopicPartitions > currently uses TreeMap but TopicPartition does not implement Comparable. > Since ordering is not important, HashMap is the most appropriate data > structure here, and the one I meant to use to begin with. > The fix will replace TreeMap with HashMap. > This issue was found by @jianbzhou and credit should be given to him. -- This message was sent by Atlassian JIRA (v6.3.4#6332)