[
https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286476#comment-15286476
]
ASF GitHub Bot commented on STORM-1842:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1424
STORM-1842 (1.x) Forward references in storm.thrift cause tooling issues
For master: #1423
Please refer STORM-1842 for more details.
* python doesn't support forward reference so ttypes.py has a problem
regarding this issue
* reorder HBPulse, HBRecords, HBNodes to resolve forward reference issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1842-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1424
----
commit 4c7117d75f80b820da110c3abee88134ca6ecaaa
Author: Jungtaek Lim <kabh...@gmail.com>
Date: 2016-05-17T11:45:03Z
STORM-1842 Forward references in storm.thrift cause tooling issues
* python doesn't support forward reference so ttypes.py has a problem
regarding this issue
* reorder HBPulse, HBRecords, HBNodes to resolve forward reference issue
----
> Forward references in storm.thrift cause tooling issues
> -------------------------------------------------------
>
> Key: STORM-1842
> URL: https://issues.apache.org/jira/browse/STORM-1842
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Barry Hart
> Priority: Critical
> Attachments: ttypes.py
>
>
> In recent versions of Storm (starting with version 1.0.0, I believe),
> storm.thrift uses several types before they are declared:
> * HBPulse
> * HBRecords
> * HBNodes
> These types are used in the definition of HBMessageData.
> This causes issues with downstream tools. For example, generating Python
> wrappers for the Storm Thrift types creates a module that will not import
> successfully.
> Would it be possible to reorder this code to define the types before using
> them? This appears to be a simple change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
