[ https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286544#comment-15286544 ]
ASF GitHub Bot commented on STORM-1842: --------------------------------------- Github user barrywhart commented on the pull request: https://github.com/apache/storm/pull/1423#issuecomment-219707172 The change looks good to me. Are the build failures related to this change? https://travis-ci.org/apache/storm/jobs/130816708#L1162 It looks like something unrelated: ```[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default) on project storm-hive: Error resolving project artifact: Could not transfer artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.3-jhyde from/to sonatype-apache (https://repository.apache.org/releases/): Connect to repository.apache.org:443 [repository.apache.org/140.211.11.112] failed: Connection timed out for project org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.3-jhyde -> [Help 1]``` > Forward references in storm.thrift cause tooling issues > ------------------------------------------------------- > > Key: STORM-1842 > URL: https://issues.apache.org/jira/browse/STORM-1842 > Project: Apache Storm > Issue Type: Bug > Components: storm-core > Affects Versions: 1.0.0 > Reporter: Barry Hart > Assignee: Jungtaek Lim > Priority: Critical > Attachments: ttypes.py > > > In recent versions of Storm (starting with version 1.0.0, I believe), > storm.thrift uses several types before they are declared: > * HBPulse > * HBRecords > * HBNodes > These types are used in the definition of HBMessageData. > This causes issues with downstream tools. For example, generating Python > wrappers for the Storm Thrift types creates a module that will not import > successfully. > Would it be possible to reorder this code to define the types before using > them? This appears to be a simple change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)