Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785042
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -184,15 +216,17 @@ public void commit(long txid) {
JedisCommands commands = null;
try {
commands = jedisContainer.getInstance();
- if (!pendingCommit.isEmpty()) {
+ if (!pendingCommit.isEmpty() ||
!pendingDeleteCommit.isEmpty()) {
commands.hmset(namespace, pendingCommit);
--- End diff --
Redis may throw error if pendingCommit is empty. you may want to confirm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
