Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66785037
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -163,15 +190,20 @@ public void prepareCommit(long txid) {
LOG.debug("Prepared txn already exists, will merge", txid);
pendingPrepare.putAll(pendingCommit);
}
- if (!pendingPrepare.isEmpty()) {
+ if (!pendingPrepare.isEmpty() ||
!pendingDeletePrepare.isEmpty()) {
commands.hmset(prepareNamespace, pendingPrepare);
+ commands.hdel(prepareNamespace,
pendingDeletePrepare.toArray(new String[pendingDeletePrepare.size()]));
--- End diff --
Shouldn't you save the pendingDeletePrepare keys separately into a redis
hashset. If a previously saved key (only in redis) is deleted, this may not
work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
