[
https://issues.apache.org/jira/browse/STORM-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327285#comment-15327285
]
ASF GitHub Bot commented on STORM-1886:
---------------------------------------
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r66784993
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -104,9 +109,11 @@ private void initPendingCommit() {
if (commands.exists(prepareNamespace)) {
LOG.debug("Loading previously prepared commit from {}",
prepareNamespace);
pendingCommit =
Collections.unmodifiableMap(commands.hgetAll(prepareNamespace));
+ pendingDeleteCommit = Collections.emptySet();
} else {
LOG.debug("No previously prepared commits.");
pendingCommit = Collections.emptyMap();
+ pendingDeleteCommit = Collections.emptySet();
--- End diff --
pendingDeleteCommits should probably be saved to a separate namespace say a
redis set?
> Extend KeyValueState interface with delete method
> -------------------------------------------------
>
> Key: STORM-1886
> URL: https://issues.apache.org/jira/browse/STORM-1886
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Balazs Kossovics
>
> Even if the implementation of checkpointing only uses the get/put methods of
> the KeyValueState interface, the existance of a delete method could be really
> useful in the general case.
> I made a first implementation, what do you think about?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
