[ https://issues.apache.org/jira/browse/STORM-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346653#comment-15346653 ]
ASF GitHub Bot commented on STORM-1886: --------------------------------------- Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68261133 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -77,7 +81,8 @@ public RedisKeyValueState(String namespace, JedisCommandsInstanceContainer jedis this.keySerializer = keySerializer; this.valueSerializer = valueSerializer; this.jedisContainer = jedisContainer; - this.pendingPrepare = new ConcurrentHashMap<>(); --- End diff -- Using guava's `Optional` seems like a good idea to you? > Extend KeyValueState interface with delete method > ------------------------------------------------- > > Key: STORM-1886 > URL: https://issues.apache.org/jira/browse/STORM-1886 > Project: Apache Storm > Issue Type: Improvement > Reporter: Balazs Kossovics > > Even if the implementation of checkpointing only uses the get/put methods of > the KeyValueState interface, the existance of a delete method could be really > useful in the general case. > I made a first implementation, what do you think about? -- This message was sent by Atlassian JIRA (v6.3.4#6332)