[
https://issues.apache.org/jira/browse/STORM-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341898#comment-15341898
]
ASF GitHub Bot commented on STORM-1883:
---------------------------------------
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1462
Are there any functional changes here? I'm all in favor of using standard
java interfaces, but I don't see any benefits of `closeable` being used here.
Possible changes could include:
- Using the try-with-resources idiom now that FileReader is `closeable` [1]
- Concrete classes no longer have to catch their own `IOException`s since
close is declared to throw that [2]
[1] -
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
[2] -
https://github.com/darionyaphet/storm/blob/ad74ad10012df6999c94652993bcd66e90db53ff/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/TextFileReader.java#L104
> FileReader extends Closeable Interface
> --------------------------------------
>
> Key: STORM-1883
> URL: https://issues.apache.org/jira/browse/STORM-1883
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hdfs
> Affects Versions: 1.0.0, 1.0.1
> Reporter: darion yaphet
> Priority: Minor
>
> use Closeable Interface to decorate FileReader to support close()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
