[ 
https://issues.apache.org/jira/browse/STORM-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370317#comment-15370317
 ] 

ASF GitHub Bot commented on STORM-1883:
---------------------------------------

Github user darionyaphet commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1462#discussion_r70212495
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/FileReader.java 
---
    @@ -20,10 +20,11 @@
     
     import org.apache.hadoop.fs.Path;
     
    +import java.io.Closeable;
     import java.io.IOException;
     import java.util.List;
     
    -interface FileReader {
    +interface FileReader extends Closeable{
    --- End diff --
    
    fixed :)


> FileReader extends Closeable Interface
> --------------------------------------
>
>                 Key: STORM-1883
>                 URL: https://issues.apache.org/jira/browse/STORM-1883
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-hdfs
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: darion yaphet
>            Assignee: darion yaphet
>            Priority: Minor
>
> use Closeable Interface to decorate FileReader to support close()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to