[
https://issues.apache.org/jira/browse/STORM-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374287#comment-15374287
]
ASF GitHub Bot commented on STORM-1965:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1559
STORM-1965 Show warning message when dot is used for topology name or
component name
* since having dot to its name will bother most of metrics consumer
It can be port back easily, and I'd like to get this merged to 1.x, and
1.0.x too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1559.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1559
----
commit b114430c6e4a6a1a7975ae5df75098c3573e193e
Author: Jungtaek Lim <[email protected]>
Date: 2016-07-13T03:43:44Z
STORM-1965 Show warning message when dot is used for topology name or
component name
* since having dot to its name will bother most of metrics consumer
----
> Show warning message when dot ('.') is used for topology name or component
> name
> -------------------------------------------------------------------------------
>
> Key: STORM-1965
> URL: https://issues.apache.org/jira/browse/STORM-1965
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Minor
>
> We're exposing metrics to metrics consumer, and most of them are storing
> metrics to time-series DB.
> Well-known common rule of generating metric name for these DB is using dot
> ('.') to separate parts, so that it can be parsed easily when needed.
> For example, graphite separates part of metric name to dot, and support
> wildcard for each part. Note that it doesn't support wildcard matching
> multiple parts.
> Since topology name or component name having dots are not common case to use
> case of user, I think we can warn users to not having dots on their topology
> name or component name. We can even restrict to not having dots if we all are
> really OK with this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
