[ 
https://issues.apache.org/jira/browse/STORM-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374401#comment-15374401
 ] 

ASF GitHub Bot commented on STORM-1965:
---------------------------------------

Github user abhishekagarwal87 commented on the issue:

    https://github.com/apache/storm/pull/1559
  
    These warning messages can be confusing for someone who is not familiar 
with time series db and the special effect of dot. If at all, these warning 
messages should be in the MetricConsumer Implementation for the time series DB 
and not in the storm submitter class. 


> Show warning message when dot ('.') is used for topology name or component 
> name
> -------------------------------------------------------------------------------
>
>                 Key: STORM-1965
>                 URL: https://issues.apache.org/jira/browse/STORM-1965
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>            Priority: Minor
>
> We're exposing metrics to metrics consumer, and most of them are storing 
> metrics to time-series DB.
> Well-known common rule of generating metric name for these DB is using dot 
> ('.') to separate parts, so that it can be parsed easily when needed.
> For example, graphite separates part of metric name to dot, and support 
> wildcard for each part. Note that it doesn't support wildcard matching 
> multiple parts.
> Since topology name or component name having dots are not common case to use 
> case of user, I think we can warn users to not having dots on their topology 
> name or component name. We can even restrict to not having dots if we all are 
> really OK with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to