[ 
https://issues.apache.org/jira/browse/STORM-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385421#comment-15385421
 ] 

ASF GitHub Bot commented on STORM-1600:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1575#discussion_r71470446
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -1772,6 +1783,7 @@ public static String uuid() {
         public static void exitProcess (int val, String msg) {
             String combinedErrorMessage = "Halting process: " + msg;
             LOG.error(combinedErrorMessage, new 
RuntimeException(combinedErrorMessage));
    +        isJVMShutdownInitiated.set(Boolean.TRUE);
    --- End diff --
    
    ShellSpout and ShellBolt just call System.exit() directly from their die() 
method. You may want to change those too.


> Do not report errors when the worker shutdown is in progress
> ------------------------------------------------------------
>
>                 Key: STORM-1600
>                 URL: https://issues.apache.org/jira/browse/STORM-1600
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>
> Usually in a worker, some uncaught exception in an executor threads leads to 
> process exit. Process exit is not instantaneous and it first triggers the 
> shutdown. The shutdown initiation usually results in network connections 
> closing e.g. zookeeper, hdfs in other threads causing other exceptions. These 
> threads end up reporting their exceptions as well. It confuses the user who 
> can these errors on UI but not the actual root cause of shutdown hidden 
> beneath new errors. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to