[
https://issues.apache.org/jira/browse/STORM-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387120#comment-15387120
]
ASF GitHub Bot commented on STORM-1600:
---------------------------------------
Github user abellina commented on a diff in the pull request:
https://github.com/apache/storm/pull/1575#discussion_r71644658
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -205,15 +205,17 @@
:report-error-and-die (reify
Thread$UncaughtExceptionHandler
(uncaughtException [this _ error]
- (try
- ((:report-error <>) error)
- (catch Exception e
- (log-error e "Error while reporting
error to cluster, proceeding with shutdown")))
- (if (or
- (Utils/exceptionCauseIsInstanceOf
InterruptedException error)
- (Utils/exceptionCauseIsInstanceOf
java.io.InterruptedIOException error))
- (log-message "Got interrupted excpetion
shutting thread down...")
- ((:suicide-fn <>)))))
+ (if (Utils/isShutdownUnderProgress)
+ (log-warn error "Uncaught exception in
thread after jvm shutdown")
+ ((try
+ ((:report-error <>) error)
+ (catch Exception e
+ (log-error e "Error while reporting
error to cluster, proceeding with shutdown")))
+ (if (or
+ (Utils/exceptionCauseIsInstanceOf
InterruptedException error)
+ (Utils/exceptionCauseIsInstanceOf
java.io.InterruptedIOException error))
+ (log-message "Got interrupted
excpetion shutting thread down...")
--- End diff --
nitpick: fix spelling of exception.
> Do not report errors when the worker shutdown is in progress
> ------------------------------------------------------------
>
> Key: STORM-1600
> URL: https://issues.apache.org/jira/browse/STORM-1600
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
> Usually in a worker, some uncaught exception in an executor threads leads to
> process exit. Process exit is not instantaneous and it first triggers the
> shutdown. The shutdown initiation usually results in network connections
> closing e.g. zookeeper, hdfs in other threads causing other exceptions. These
> threads end up reporting their exceptions as well. It confuses the user who
> can these errors on UI but not the actual root cause of shutdown hidden
> beneath new errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
