GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1595
STORM-2006 Storm metrics feature improvement: support per-worker level
metrics aggregation
PR for 1.x : #1594
* SystemBolt handles task level metrics via two mode
* non-aggregate: same to previous, just applying expansion and pass to
MetricConsumerBolts
* aggregate: apply expansion, do aggregation, pass aggregated metrics to
MetricConsumerBolts
* all task level metrics should pass by SystemBolt within its worker
* it drops all connections between tasks and MetricsConsumerBolts
* only SystemBolts and MetricConsumerBolts will be connected
* move configurations: expandMapType and metricNameSeparator to global
* since SystemBolt needs to handle expansion when both worker level
aggregation and expandMapType are turned on
This could break #1445 and it's already broken. We ideally want to stop
adding new feature on 1.x and concentrate on 2.x but life is not easy.
I can volunteer to fix the conflict if this PR breaks #1445 in many places.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1595
----
commit 8d1bc0b7ca2e50d45af3bc1bf41944925611910e
Author: Jungtaek Lim <[email protected]>
Date: 2016-07-25T13:43:02Z
STORM-2006 Storm metrics feature improvement: support per-worker level
metrics aggregation
* SystemBolt handles task level metrics via two mode
** non-aggregate: same to previous, just applying expansion and pass to
MetricConsumerBolts
** aggregate: apply expansion, do aggregation, pass aggregated metrics to
MetricConsumerBolts
* all task level metrics should pass by SystemBolt within its worker
** it drops all connections between tasks and MetricsConsumerBolts
** only SystemBolts and MetricConsumerBolts will be connected
* move configurations: expandMapType and metricNameSeparator to global
** since SystemBolt needs to handle expansion when both worker level
aggregation and expandMapType are turned on
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
