Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1595#discussion_r72479602
--- Diff: conf/defaults.yaml ---
@@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100
topology.disruptor.batch.timeout.millis: 1
topology.disable.loadaware: false
topology.state.checkpoint.interval.ms: 1000
+topology.metrics.aggregate.per.worker: false
--- End diff --
@HeartSaVioR
If I'm following the code/conversation correctly, this flag essentially
changes the IMetricConsumer interface (specifically the value set in the
DataPoint class - which is of type Object). That makes me very uneasy.
Is there a way to make the interface more strongly typed?
Thinking out loud: What about splitting the interface in two: One that does
aggregation and one that doesn't, then switching calls based on which interface
is implemented?
I'm not opposed to breaking backwards compatibility and bumping up the
major version if necessary. In other words I'd rather see a clean design than
preserve backwards compatibility with respect to the metrics features.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
