[
https://issues.apache.org/jira/browse/STORM-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394017#comment-15394017
]
ASF GitHub Bot commented on STORM-1991:
---------------------------------------
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1587
@darionyaphet can you please clarify why this patch is needed? In my
understanding it shouldn't be necessary to have any logic for auto commit
interval. If one wishes to set the auto commit interval, one can do so using
the kafka properties `autocommit.interval.ms` and `autocommit.enable`. These
properties will then be passed the `KafkaConsumer`
[here](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L350)
The [commit
timer](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L111)
is only used when in non auto commit mode. The 500 is only the initial delay.
One can make this initial delay configurable, but it may not be of extreme
importance to do so.
> Support auto.commit.interval in Kafka Client
> --------------------------------------------
>
> Key: STORM-1991
> URL: https://issues.apache.org/jira/browse/STORM-1991
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Affects Versions: 1.0.0
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> Support auto.commit.interval in Kafka Client
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
