[
https://issues.apache.org/jira/browse/STORM-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394577#comment-15394577
]
ASF GitHub Bot commented on STORM-1991:
---------------------------------------
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1587
@darionyaphet this kafka spout does not use zookeeper as the new Kafka API
writes the offsets to a topic rather than to zookeeper. As I mentioned in the
initial comment, this change is not necessary. Furthermore, all the kafka
properties are supposed to go in a map, as illustrated in [this
example](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java#L115-L123)
At last, the commitTimer is not used in auto commit mode.
I would like to suggest that you close this PR.
> Support auto.commit.interval in Kafka Client
> --------------------------------------------
>
> Key: STORM-1991
> URL: https://issues.apache.org/jira/browse/STORM-1991
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Affects Versions: 1.0.0
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> Support auto.commit.interval in Kafka Client
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
