[ 
https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394756#comment-15394756
 ] 

ASF GitHub Bot commented on STORM-2006:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1595#discussion_r72355902
  
    --- Diff: conf/defaults.yaml ---
    @@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100
     topology.disruptor.batch.timeout.millis: 1
     topology.disable.loadaware: false
     topology.state.checkpoint.interval.ms: 1000
    +topology.metrics.aggregate.per.worker: false
    --- End diff --
    
    I also think current pluggable metrics consumer design is too flexible. 
Users rely on metrics consumers which are open source from individual or 
specific vendor, which is easy to be not maintained. I guess most popular 
implementation of metrics consumer is verisign/storm-graphite, and it's not 
maintained for months. We should provide stable consumer implementation. If we 
don't want to handle various time-series DBs, we can open at most pluggable 
connector interface.


> Storm metrics feature improvement: support per-worker level metrics 
> aggregation
> -------------------------------------------------------------------------------
>
>                 Key: STORM-2006
>                 URL: https://issues.apache.org/jira/browse/STORM-2006
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>    Affects Versions: 1.1.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> Storm provides per-task level metrics which could be huge when topology has a 
> number of tasks. 
> Task level metric is useful for determining load balance between tasks, but 
> it doesn't need to be time-series fashion.
> Before introducing topology level component like TopologyMaster for JStorm, 
> we can utilize SystemBolt to aggregate task level metrics to per-worker level 
> metrics.
> We should provide options and this feature should be turned off by default to 
> keep backward compatibility. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to