[
https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396720#comment-15396720
]
ASF GitHub Bot commented on STORM-2006:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1595#discussion_r72548331
--- Diff: conf/defaults.yaml ---
@@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100
topology.disruptor.batch.timeout.millis: 1
topology.disable.loadaware: false
topology.state.checkpoint.interval.ms: 1000
+topology.metrics.aggregate.per.worker: false
--- End diff --
@ptgoetz No worries. I didn't take your comments in that way. It was just
my criticism of **current metrics API**.
Storm community discussed about metrics several times, and the only one
that I can get is the needs of new metrics feature.
This is a last discussion which also contains requirements of metrics
feature. I don't think we should address all of them, but addressing much of
them would be great.
http://mail-archives.us.apache.org/mod_mbox/storm-dev/201605.mbox/%3CCAF5108jB=4al0z1qmmnee7u4yx_9tzjd11bjyhktkttvjot...@mail.gmail.com%3E
Adding fixes to current metrics seems not competitive to recent metrics
from others stream frameworks, and even JStorm, which is the thing we would
eventually evaluate (I already did a first pass and looks promising) and port
if it's better. This patch only has a value with current metrics, and I don't
want to break backward compatibility because of will-be-deprecated-and-dropped
feature.
> Storm metrics feature improvement: support per-worker level metrics
> aggregation
> -------------------------------------------------------------------------------
>
> Key: STORM-2006
> URL: https://issues.apache.org/jira/browse/STORM-2006
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides per-task level metrics which could be huge when topology has a
> number of tasks.
> Task level metric is useful for determining load balance between tasks, but
> it doesn't need to be time-series fashion.
> Before introducing topology level component like TopologyMaster for JStorm,
> we can utilize SystemBolt to aggregate task level metrics to per-worker level
> metrics.
> We should provide options and this feature should be turned off by default to
> keep backward compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
