Stig Rohde Døssing created STORM-2014:
-----------------------------------------
Summary: New Kafka spout duplicates checking if failed messages
have reached max retries
Key: STORM-2014
URL: https://issues.apache.org/jira/browse/STORM-2014
Project: Apache Storm
Issue Type: Bug
Components: storm-kafka
Reporter: Stig Rohde Døssing
Assignee: Stig Rohde Døssing
The new Kafka spout has a RetryService interface that should make logic around
retrying tuples pluggable. The RetryServiceExponentialBackoff class has code
for setting a max retry count, and dropping messages once they reach the retry
limit. This functionality is duplicated by the spout in the fail method, which
means that the user must set different maxRetries for the RetryService and the
spout in order for the RetryService code to be hit when dropping messages.
I think the retry logic belongs in the RetryService interface, and should be
removed from the spout. It would also be good if the RetryService could
indicate if a message will be retried or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
