[GitHub] storm pull request #1605: STORM-2014: Put logic around dropping messages int...

[srdo]

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/1605

    STORM-2014: Put logic around dropping messages into RetryService, rem…

    …ove maxRetry setting from new KafkaSpout
    
    https://issues.apache.org/jira/browse/STORM-2014
    
    This PR removes maxRetry from the KafkaSpout and changes the RetryService 
interface slightly so the schedule method can communicate back to the spout 
that the message should be dropped. Retry logic belongs to the RetryService 
interface, and it's nice for users if they can easily plug in their own 
handling of messages that will be dropped (custom logging for example).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2014

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1605
    
----
commit 432f932a70b0bd21f06cd6f36386404eab194e0a
Author: Stig Rohde Døssing <stigdoess...@gmail.com>
Date:   2016-08-02T17:17:02Z

    STORM-2014: Put logic around dropping messages into RetryService, remove 
maxRetry setting from new KafkaSpout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---