[
https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409223#comment-15409223
]
ASF GitHub Bot commented on STORM-2016:
---------------------------------------
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1608
[STORM-2016](http://issues.apache.org/jira/browse/STORM-2016) can also
resolve [STORM-1435](http://issues.apache.org/jira/browse/STORM-1435) via
applying different strategy, specifying dependencies to --jars and --packages
instead of creating uber jar.
(Yes in fact STORM-2016 is started to resolve STORM-1435.)
Note that `storm sql` adds storm-sql-core and its transitive dependencies
to classpath to run Runner, and also adds storm-sql-runtime and its transitive
dependencies to classpath to run topology by adding them to --jars option.
With [STORM-2023](https://issues.apache.org/jira/browse/STORM-2023)
(#1610), we can run the example of storm-sql by below command.
> ./bin/storm sql order_filtering.sql order_filtering --packages
"org.apache.storm:storm-sql-kafka:1.1.1-SNAPSHOT,org.apache.storm:storm-kafka:1.1.1-SNAPSHOT,org.apache.kafka:kafka_2.10:0.8.2.2\!org.slf4j:slf4j-log4j12,org.apache.kafka:kafka-clients:0.8.2.2"
Without STORM-2023, we still have a chance to run the example of storm-sql
by below command
> ./bin/storm sql order_filtering.sql order_filtering --packages
"org.apache.storm:storm-sql-kafka:1.1.1-SNAPSHOT,org.apache.storm:storm-kafka:1.1.1-SNAPSHOT,org.apache.kafka:kafka_2.10:0.8.2.2\!org.slf4j:slf4j-log4j12,org.apache.kafka:kafka-clients:0.8.2.2,org.apache.calcite:calcite-core:1.4.0-incubating\!commons-dbcp:commons-dbcp\!com.google.code.findbugs:jsr305\!org.codehaus.janino:janino\!org.codehaus.janino:commons-compiler\!org.pentaho:pentaho-aggdesigner-algorithm\!com.fasterxml.jackson.core:jackson-annotations"
> Topology submission improvement: support adding local jars and maven
> artifacts on submission
> --------------------------------------------------------------------------------------------
>
> Key: STORM-2016
> URL: https://issues.apache.org/jira/browse/STORM-2016
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> This JIRA tracks actual work on below proposal / design document.
> https://cwiki.apache.org/confluence/display/STORM/A.+Design+doc%3A+adding+jars+and+maven+artifacts+at+submission
> Proposal discussion thread is here:
> http://mail-archives.apache.org/mod_mbox/storm-dev/201608.mbox/%3ccaf5108i9+tjanz0lgrktmkvqel7f+53k9uyzxct6zhsu6oh...@mail.gmail.com%3E
> Let's post on discussion thread if we have any opinions / ideas on this
> instead of leaving comments on this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
