[
https://issues.apache.org/jira/browse/STORM-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411653#comment-15411653
]
ASF GitHub Bot commented on STORM-2026:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1616#discussion_r73856052
--- Diff: storm-core/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -204,8 +204,8 @@ public static Executor mkExecutor(Map workerData,
List<Long> executorId, Map<Str
throw Utils.wrapInRuntime(ex);
}
}
- executor.init(idToTask);
+ executor.idToTask = idToTask;
--- End diff --
@HeartSaVioR It is better to pass `idToTask` object as part of constructor
instead of setting here. idToTask can be created before calling constructor.
> Inconsistency between (SpoutExecutor, BoltExecutor) and (spout-transfer-fn,
> bolt-transfer-fn)
> ---------------------------------------------------------------------------------------------
>
> Key: STORM-2026
> URL: https://issues.apache.org/jira/browse/STORM-2026
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> As I left the comment from
> https://github.com/apache/storm/pull/1445#discussion_r73255197 for pull
> request, there's some difference between SpoutExecutor / BoltExecutor and
> spout-transfer-fn / bolt-transfer-fn.
> While it's not that big to fix, I just want to not block port work and just
> address from here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
