[ 
https://issues.apache.org/jira/browse/STORM-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411803#comment-15411803
 ] 

ASF GitHub Bot commented on STORM-2026:
---------------------------------------

Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1616#discussion_r73873775
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java ---
    @@ -79,8 +79,11 @@ public SpoutExecutor(final Map workerData, final 
List<Long> executorId, Map<Stri
             this.spoutThrottlingMetrics = new SpoutThrottlingMetrics();
         }
     
    -    @Override
         public void init(final Map<Integer, Task> idToTask) {
    +        while (!stormActive.get()) {
    --- End diff --
    
    The assumption here is that this method is invoked only once. Do no we want 
to handle for multiple invocations?


> Inconsistency between (SpoutExecutor, BoltExecutor) and (spout-transfer-fn, 
> bolt-transfer-fn)
> ---------------------------------------------------------------------------------------------
>
>                 Key: STORM-2026
>                 URL: https://issues.apache.org/jira/browse/STORM-2026
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 2.0.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> As I left the comment from 
> https://github.com/apache/storm/pull/1445#discussion_r73255197 for pull 
> request, there's some difference between SpoutExecutor / BoltExecutor and 
> spout-transfer-fn / bolt-transfer-fn.
> While it's not that big to fix, I just want to not block port work and just 
> address from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to