Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1635#discussion_r75429055
  
    --- Diff: 
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java
 ---
    @@ -67,8 +68,9 @@ public ExprCompiler(PrintWriter pw, JavaTypeFactory 
typeFactory) {
       public String visitInputRef(RexInputRef rexInputRef) {
         String name = reserveName();
         String typeName = javaTypeName(rexInputRef);
    +    String boxedTypeName = boxedJavaTypeName(rexInputRef);
         pw.print(String.format("%s %s = (%s)(_data.get(%d));\n", typeName, 
name,
    -                           typeName, rexInputRef.getIndex()));
    +                           boxedTypeName, rexInputRef.getIndex()));
    --- End diff --
    
    Converting Object to primitive type is allowed for Java 7 or upper, but 
Janino throws error while compiling script so I just converted to boxed type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to