Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1635#discussion_r75822913
  
    --- Diff: 
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
    @@ -137,18 +137,12 @@ public void submit(
         }
       }
     
    -  private void packageTopology(Path jar, CompilingClassLoader cl, 
AbstractTridentProcessor processor) throws IOException {
    +  private void packageEmptyTopology(Path jar) throws IOException {
    --- End diff --
    
    Can you put some comments on why are we packaging an empty jar and where 
the code for executing the topology is going to be ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to