Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1626#discussion_r75471422
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -366,14 +386,29 @@ protected boolean
didDownloadBlobsForTopologySucceed(String stormconfPath, Strin
blobFileNames.add(ret);
}
}
- for (String string : blobFileNames) {
- if (!Utils.checkFileExists(string))
- return false;
- }
- return true;
+
+ return didDownloadBlobsForTopologySucceed(targetDir,
blobFileNames);
}
/**
+ * Assert if all dependencies blobs are downloaded for the given
topology
+ *
+ * @param stormcodePath
+ * @param targetDir
+ * @return
+ */
+ protected boolean didDownloadDependenciesForTopologySucceed(String
stormcodePath, String targetDir) throws IOException {
--- End diff --
`areDependencyFilesDownloaded` would be fine for me since we're commenting
like that.
Personally `check*` feels assertion which throws some exceptions if
predicate doesn't hold true, but it's just me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
