Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1626#discussion_r75471479
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -344,12 +347,29 @@ private void downloadDistributeStormCode(Map conf,
String stormId, String master
/**
* Assert if all blobs are downloaded for the given topology
- *
+ *
+ * @param targetDir
+ * @param blobFileNames
+ * @return
+ */
+ protected boolean didDownloadBlobsForTopologySucceed(String targetDir,
List<String> blobFileNames) throws IOException {
+ for (String string : blobFileNames) {
+ if (!Utils.checkFileExists(targetDir, string)) {
+ LOG.info("Fail to find downloaded file: dir {} filename
{}", targetDir, string);
+ return false;
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Assert if all blobs in blobstore map are downloaded for the given
topology
+ *
* @param stormconfPath
* @param targetDir
* @return
*/
- protected boolean didDownloadBlobsForTopologySucceed(String
stormconfPath, String targetDir) throws IOException {
+ protected boolean
didDownloadBlobsInBlobStoreMapForTopologySucceed(String stormconfPath, String
targetDir) throws IOException {
--- End diff --
Same as above, `areBlobsDownloaded` would be fine for me since we're
commenting like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
