[
https://issues.apache.org/jira/browse/STORM-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449339#comment-15449339
]
Robert Joseph Evans commented on STORM-1985:
--------------------------------------------
Please put the class in org.apache.storm.command. A pull request against
https://github.com/apache/storm is preferable to posting a patch in the JIRA.
Just make sure to include the jira number (STORM-1985) in the title of the pull
request.
There are a number of design/usability choices that I would like to see fixed.
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/command/Blobstore.java
Has a better framework for having a single command with multiple sub commands.
I would prefer to see admin be similar, having a special hard coded string with
spaces in it does not fit with the rest of storm.
The code you posed is not complete and has a big TODO in it.
The code that you do have looks correct.
> Provide a tool for showing and killing corrupted topology
> ---------------------------------------------------------
>
> Key: STORM-1985
> URL: https://issues.apache.org/jira/browse/STORM-1985
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Kamal
> Labels: newbie
> Attachments: AdminCommands.java, proposal_admin_tool_design.docx
>
>
> After STORM-1976, Nimbus doesn't clean up corrupted topologies.
> (corrupted topology means the topology whose codes are not available on
> blobstore.)
> Also after STORM-1977, no Nimbus is gaining leadership if one or more
> topologies are corrupted, which means all nimbuses will be no-op.
> So we should provide a tool to kill specific topology without accessing
> leader nimbus (because there's no leader nimbus at that time). The tool
> should also determine which topologies are corrupted, and show its list or
> clean up automatically.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
