Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1656#discussion_r77945289
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -277,6 +277,35 @@ public Stream join(List<Stream> streams, List<Fields>
joinFields, Fields outFiel
outFields);
}
+ public Stream joinSQL(Stream s1, Fields joinFields1, Stream s2, Fields
joinFields2, Fields outFields) {
--- End diff --
Why are we exposing new apis in TridentTopology and what extra
functionality does joinSQL provide ? It may confuse users if they see both Join
and JoinSQL. IMO, we should have only `join` in the trident apis. The SQL
specific parts should be private and may be defined outside of TridentTopology
if its specific to SQL implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
