Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1656#discussion_r77984622
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -277,6 +277,35 @@ public Stream join(List<Stream> streams, List<Fields>
joinFields, Fields outFiel
outFields);
}
+ public Stream joinSQL(Stream s1, Fields joinFields1, Stream s2, Fields
joinFields2, Fields outFields) {
--- End diff --
May be you can have `join` with extra mode parameter as you mentioned. Also
good to have some javadocs to explain the difference. I don't get what
preserving parameters means without going through the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
