Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1690#discussion_r79529486
--- Diff:
external/sql/storm-sql-core/src/test/org/apache/storm/sql/compiler/backends/trident/TestPlanCompiler.java
---
@@ -274,4 +274,9 @@ private void waitForCompletion(long timeout,
Callable<Boolean> cond) throws Exce
Thread.sleep(100);
}
}
+
+ private void assertArrayWithoutOrder(List<Values> expected,
List<List<Object>> actual) {
+ Assert.assertTrue("Two arrays are not same!\n"+ "Expected: " +
expected + "\n" + "Actual: " + actual,
--- End diff --
@satishd Thanks for the detailed review. Changed to `Two lists` :) also
rename the method name to represent list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
