Github user srdo commented on the issue:
This more or less seems done to me. The only thing that bugs me is Storm
double acking tuples. The only case I could think of is if tuples time out and
they're later acked by the acker bolt, but it seems like the executor actually
handles that. As far as I can tell hitting the changed case in
findNextCommitOffset should actually indicate a bug in the code, because we've
received an ack for a tuple we've already committed to Kafka, which shouldn't
be possible unless a tuple is double acked. I don't think that should be
happening unless the spout is doing something wrong?
@jfenc91 are you still seeing that case (L498) getting hit even with these
changes and the other PR?
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket