Github user srdo commented on a diff in the pull request:
    --- Diff: 
    @@ -266,26 +266,32 @@ private void doSeekRetriableTopicPartitions() {
                 if (offsetAndMeta != null) {
           , offsetAndMeta.offset() + 1);  // 
seek to the next offset that is ready to commit in next commit cycle
                 } else {
    -                kafkaConsumer.seekToEnd(toArrayList(rtp));    // Seek to 
last committed offset
    +      , acked.get(rtp).committedOffset + 
1);    // Seek to last committed offset
    --- End diff --
    @jfenc91 About this being tested: If the two tests you mentioned run fine 
without this change, would you mind adding one that tests this? Maybe something 
like have a topic with a few messages in it and fail the first message, then 
check that the spout doesn't skip the messages following the failed message?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to