Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1710#discussion_r80508806
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClientHandler.java ---
    @@ -69,7 +69,7 @@ else if(evm instanceof HBMessage) {
     
         @Override
         public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
event) {
    -        LOG.error("Connection to pacemaker failed", event.getCause());
    +        LOG.error("Connection to pacemaker failed. Trying to reconnect 
{}", event.getCause().getMessage());
    --- End diff --
    
    I don't think we want the stack. It ends up absolutely filling Nimbus logs 
with relatively useless messages when a Pacemaker node goes down. I'm open to 
ideas, though, because a trace for an NPE or something would be nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to