Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1710#discussion_r80791012
--- Diff:
storm-core/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java ---
@@ -159,10 +162,6 @@ public void set_worker_hb(String path, byte[] data,
List<ACL> acls) {
ret = details;
}
}
- if(ret == null) {
- throw new HBExecutionException("Failed to get a
response.");
- }
- LOG.debug("Successful get_worker_hb");
return ret;
--- End diff --
Do we need the ret == null check before this? Is it possible to get more
then one response and all of them are bogus?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
