Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93551580
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -218,7 +223,11 @@ public void nextTuple() {
}
if (poll()) {
- setWaitingToEmit(pollKafkaBroker());
+ try {
+ setWaitingToEmit(pollKafkaBroker());
+ } catch (KafkaException e) {
--- End diff --
@srdo good point, but the main point is also that the code that is handling
the interrupt exceptions is very fragile. Right now you were able to catch
this, but it's very difficult for other devs to code accounting for that.
@liurenjie1024 we are basically catching and logging the exception. Is that
really the intent? Is there a scenario that we should not catch the exception,
in which we would rather let the process die, and then restart ? The way the
code currently works, if no new records are polled anything (i.e. an exception
occurred) `waitingToEmit` will always be false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
