Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93294533
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -218,7 +223,11 @@ public void nextTuple() {
}
if (poll()) {
- setWaitingToEmit(pollKafkaBroker());
+ try {
+ setWaitingToEmit(pollKafkaBroker());
+ } catch (KafkaException e) {
--- End diff --
I think you should catch
https://kafka.apache.org/0100/javadoc/org/apache/kafka/common/errors/RetriableException.html
instead, it seems to cover all the exceptions that are expected to be
transient (leader change for example, through InvalidMetadataException).
Catching KafkaException will break interrupt handling (see
https://github.com/apache/storm/pull/1821) because InterruptException is an
instance of KafkaException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
